[
https://issues.apache.org/jira/browse/THRIFT-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363387#comment-16363387
]
ASF GitHub Bot commented on THRIFT-4460:
----------------------------------------
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1472#discussion_r168062703
--- Diff: build/docker/scripts/sca.sh ---
@@ -49,6 +49,10 @@ flake8 --ignore=E501 test/test.py
flake8 --ignore=E501,E722 test/crossrunner
flake8 test/features
+# PHP code style
+composer install --quiet
+./vendor/bin/phpcs
--- End diff --
@RobberPhex this change is causing errors in other builds even though I
have rebased on master, see:
https://travis-ci.org/apache/thrift/jobs/341109387
I am going to disable it for now.
> php library use PSR-2
> ---------------------
>
> Key: THRIFT-4460
> URL: https://issues.apache.org/jira/browse/THRIFT-4460
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Library
> Affects Versions: 0.11.0
> Reporter: Robert Lu
> Assignee: Robert Lu
> Priority: Minor
> Fix For: 0.12.0
>
>
> PHP Library can use [PSR-2|http://www.php-fig.org/psr/psr-2/] as code standard
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
