Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1472#discussion_r168062703
  
    --- Diff: build/docker/scripts/sca.sh ---
    @@ -49,6 +49,10 @@ flake8 --ignore=E501 test/test.py
     flake8 --ignore=E501,E722 test/crossrunner
     flake8 test/features
     
    +# PHP code style
    +composer install --quiet
    +./vendor/bin/phpcs
    --- End diff --
    
    @RobberPhex this change is causing errors in other builds even though I 
have rebased on master, see:
    
    https://travis-ci.org/apache/thrift/jobs/341109387
    
    I am going to disable it for now.


---

Reply via email to