[
https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387972#comment-16387972
]
ASF GitHub Bot commented on THRIFT-4489:
----------------------------------------
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1491#discussion_r172557523
--- Diff: test/tests.json ---
@@ -221,7 +221,8 @@
"framed"
],
"sockets": [
- "ip"
+ "ip",
+ "domain"
--- End diff --
You added domain tests to the haskell group, not the nodejs group.
> Unix domain socket support for NodeJS client
> --------------------------------------------
>
> Key: THRIFT-4489
> URL: https://issues.apache.org/jira/browse/THRIFT-4489
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.11.0
> Reporter: Daniel Shih
> Assignee: James E. King, III
> Priority: Major
>
> I would like to use Unix domain sockets for NodeJS client,
> Here is the proposed PR: https://github.com/apache/thrift/pull/1491
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
