[
https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405377#comment-16405377
]
ASF GitHub Bot commented on THRIFT-4489:
----------------------------------------
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1491
Okay so, here's the deal. This pull request has 9 commits and one of them
is a merge. If you want your name on the commit tag you will need to squash
and resubmit with a single commit and then I can cherry-pick it over and push
it. Otherwise if you don't care, I can squash and merge it, but my name will
end up in the "Author" field of the commit, and I will include your name in the
content of the pull request, i.e.:
```
commit 496568e57a17889f484c6275078bef2bcb43382e (HEAD -> master)
Author: James E. King III <[email protected]>
Date: Mon Mar 19 16:16:37 2018 -0400
THRIFT-4489: Add UDS support for nodejs thrift client
Patch: Daniel Shih <[email protected]>
Client: nodejs
This closes #1491
```
Let me know what you want to do. I'm fine either way.
> Unix domain socket support for NodeJS client
> --------------------------------------------
>
> Key: THRIFT-4489
> URL: https://issues.apache.org/jira/browse/THRIFT-4489
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.11.0
> Reporter: Daniel Shih
> Assignee: James E. King, III
> Priority: Major
>
> I would like to use Unix domain sockets for NodeJS client,
> Here is the proposed PR: https://github.com/apache/thrift/pull/1491
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
