[
https://issues.apache.org/jira/browse/THRIFT-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731130#comment-16731130
]
Jens Geyer commented on THRIFT-4655:
------------------------------------
{quote}I would not have expected the compiler to complain unless generating
csharp and netcore.{quote}
I repeat it again: That whole approach is doomed to fail.
There are two kinds of Keywords and one additional special case:
* KW related to IDL constructs (i.e. Thrift IDL keywords)
* KW related to the generated Output (i.e. language specific Keywords)
* special language constraints (e.g. it is illegal in C# to use a member name
equal to the surrounding type)
The first one should be very concise and the Thrift Compiler should ALWAYS
complain, regardless of the target langauge
The latter two sets of problems should not lead to a complain, rather it should
be silently handled and transformned into suitable language constructs (i.e.
prefixing KWs with @ in C#)
That's basically it. Simple, explainable, and free of unexpected reactions from
the system as a whole. At the cost of a bit more work for the implementer of
the generator.
> Parser fails on the word "from"
> -------------------------------
>
> Key: THRIFT-4655
> URL: https://issues.apache.org/jira/browse/THRIFT-4655
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
> Affects Versions: 0.9.3
> Reporter: felix wang
> Assignee: James E. King III
> Priority: Major
> Attachments: image-2018-10-25-17-08-31-856.png
>
>
> !image-2018-10-25-17-08-31-856.png!
> {color:#191f25}2018-10-25 04:04:42：[ERROR] thrift failed output: {color}
> {color:#191f25}[ERROR] thrift failed error:
> [ERROR:/tmp/pebble_idl_tmp/mkt/dis/1540454677417/idlPro/dis/src/main/thrift/mkt_dis_model_dto.thrift:887]
> (last token was 'from'){color}
> {color:#191f25}[ERROR] Failed to execute goal
> com.tuniu.thrift.tools:maven-thrift-plugin:0.1.11_1-SNAPSHOT:compile
> (thrift-java-sources) on project mkt-dis-idl: thrift did not exit cleanly.
> Review output for more information. -> [Help 1]{color}
> {color:#191f25}[ERROR] {color}
> {color:#191f25}[ERROR] To see the full stack trace of the errors, re-run
> Maven with the -e switch.{color}
> {color:#191f25}[ERROR] Re-run Maven using the -X switch to enable full debug
> logging.{color}
> {color:#191f25}[ERROR] {color}
> {color:#191f25}[ERROR] For more information about the errors and possible
> solutions, please read the following articles:{color}
> {color:#191f25}[ERROR] [Help 1]
> {color}[http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
