[ 
https://issues.apache.org/jira/browse/THRIFT-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731153#comment-16731153
 ] 

James E. King III commented on THRIFT-4655:
-------------------------------------------

What I could see is (for example...) if you generate lua and python code, and 
have the word "from", the compiler could put out a warning.  If you generate 
lua, python, and netcore code, the compiler could error out.  A command line 
option could make the language-specific keyword checking behave differently:

* Only check the languages I am generating
* Check all languages (this may not work with the compiler plugin mode)

* Language-specific keyword issues are warnings
* Language-specific keyword issues are errors

Then we need sensible defaults for these.

> Parser fails on the word "from"
> -------------------------------
>
>                 Key: THRIFT-4655
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4655
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Compiler
>    Affects Versions: 0.9.3
>            Reporter: felix wang
>            Assignee: James E. King III
>            Priority: Major
>         Attachments: image-2018-10-25-17-08-31-856.png
>
>
> !image-2018-10-25-17-08-31-856.png!
> {color:#191f25}2018-10-25 04:04:42:[ERROR] thrift failed output: {color}
> {color:#191f25}[ERROR] thrift failed error: 
> [ERROR:/tmp/pebble_idl_tmp/mkt/dis/1540454677417/idlPro/dis/src/main/thrift/mkt_dis_model_dto.thrift:887]
>  (last token was 'from'){color}
> {color:#191f25}[ERROR] Failed to execute goal 
> com.tuniu.thrift.tools:maven-thrift-plugin:0.1.11_1-SNAPSHOT:compile 
> (thrift-java-sources) on project mkt-dis-idl: thrift did not exit cleanly. 
> Review output for more information. -> [Help 1]{color}
> {color:#191f25}[ERROR] {color}
> {color:#191f25}[ERROR] To see the full stack trace of the errors, re-run 
> Maven with the -e switch.{color}
> {color:#191f25}[ERROR] Re-run Maven using the -X switch to enable full debug 
> logging.{color}
> {color:#191f25}[ERROR] {color}
> {color:#191f25}[ERROR] For more information about the errors and possible 
> solutions, please read the following articles:{color}
> {color:#191f25}[ERROR] [Help 1] 
> {color}[http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to