[
https://issues.apache.org/jira/browse/THRIFT-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915091#comment-16915091
]
Jens Geyer commented on THRIFT-4907:
------------------------------------
https://docs.microsoft.com/en-us/dotnet/standard/library-guidance/strong-naming
{quote}
This guidance is specific to publicly distributed .NET libraries, such as .NET
libraries published on NuGet.org. Strong naming is not required by most .NET
applications and should not be done by default.
✔️ CONSIDER strong naming your library's assemblies.
✔️ CONSIDER adding the strong naming key to your source control system.
A publicly available key lets developers modify and recompile your library
source code with the same key.
You shouldn't make the strong naming key public if it has been used in the past
to give special permissions in partial-trust scenarios. Otherwise, you might
compromise existing environments.
{quote}
https://docs.microsoft.com/en-us/dotnet/framework/app-domains/strong-named-assemblies
{quote}
Do not rely on strong names for security. They provide a unique identity only.
{quote}
> strong named assemblies wanted
> ------------------------------
>
> Key: THRIFT-4907
> URL: https://issues.apache.org/jira/browse/THRIFT-4907
> Project: Thrift
> Issue Type: Bug
> Components: C# - Library, netcore - Library, netstd - Library
> Affects Versions: 0.12.0
> Reporter: Benjamin Kraemer
> Assignee: Jens Geyer
> Priority: Blocker
> Fix For: 0.13.0
>
>
> In THRIFT-2947, a strong name should have been added to
> [https://www.nuget.org/packages/ApacheThrift/0.12.0.1]
> Looking at the DLL, it's not signed at all. The assembly name is still
> `Thrift, Version=0.12.0.0, Culture=neutral, PublicKeyToken=null` and
> therefore missing the `PublicKeyToken` part.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
