[ 
https://issues.apache.org/jira/browse/THRIFT-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915184#comment-16915184
 ] 

Benjamin Kraemer commented on THRIFT-4907:
------------------------------------------

We ourself don’t use strong names in our company. But I know of some customers 
that do rely on it. And all of our other dependencies offer strong names (all 
Microsoft packages, Newtonsoft.JSON, OpenTracing, GRPC).

So Thrift is currently the only NuGET package that blocks us from releasing a 
strong-named package and why we have a self-signed vendor package for that to 
circumvent it. The problem is, that this leads to name conflicts when a 
customer wants to use the official Thrift in his Lib and has a dependency on 
Jaeger.

> strong named assemblies wanted
> ------------------------------
>
>                 Key: THRIFT-4907
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4907
>             Project: Thrift
>          Issue Type: Bug
>          Components: C# - Library, netcore - Library, netstd - Library
>    Affects Versions: 0.12.0
>            Reporter: Benjamin Kraemer
>            Assignee: Jens Geyer
>            Priority: Blocker
>             Fix For: 0.13.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In THRIFT-2947, a strong name should have been added to 
> [https://www.nuget.org/packages/ApacheThrift/0.12.0.1]
> Looking at the DLL, it's not signed at all. The assembly name is still 
> `Thrift, Version=0.12.0.0, Culture=neutral, PublicKeyToken=null` and 
> therefore missing the `PublicKeyToken` part.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to