[
https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17046955#comment-17046955
]
Jens Geyer edited comment on THRIFT-5109 at 2/28/20 8:19 AM:
-------------------------------------------------------------
PR 2021, 2025 and 2026 break the appveyor build.
Seems as if the EXE is created by MSVC in the /Debug subfolder but later on
expected without /Debug at the copy step, which therefore fails.
And BTW the CMakeLists.txt need to be added to the make dist targets. I
already fixed that in master, but will also rollback it when I have to.
was (Author: jensg):
PR 2021, 2025 and 2026 break the appveyor build.
Seems as if the EXE is created by MSVC in the /Debug subfolder but later on
expected without /Debug at the copy step, which therefore fails.
> Misc CMake improvements
> -----------------------
>
> Key: THRIFT-5109
> URL: https://issues.apache.org/jira/browse/THRIFT-5109
> Project: Thrift
> Issue Type: Improvement
> Components: Build Process
> Reporter: Jens Geyer
> Assignee: Mario Emmenlauer
> Priority: Major
> Fix For: 0.14.0
>
>
> * compiler/cpp/CMakeLists.txt: Install compiler after build, like automake
> does
> * Added NodeJS to cmake build
> * Added Javascript to cmake build
> * build/cmake/DefineInstallationPaths.cmake: fixed the library path
> * build/cmake/ThriftMacros.cmake: do not enforce debug suffix 'd'
> * lib/java/CMakeLists.txt: allow to override JAVA_INSTALL_DIR
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
