[
https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083290#comment-17083290
]
Jano Svitok edited comment on THRIFT-5109 at 4/14/20, 3:35 PM:
---------------------------------------------------------------
-Would [this
change|https://github.com/apache/thrift/pull/2094/files#diff-9a86cb41bfe9d6fec8e92b71bd8e6b8bL326]
explain the problem?- I see now the point of the change
I can see in the log that {{COMMAND npm install}} run. Did also the {{npx}}
commands run? There is no mention in the log. Also no thrift*.js is installed.
was (Author: janosvitok):
Would [this
change|https://github.com/apache/thrift/pull/2094/files#diff-9a86cb41bfe9d6fec8e92b71bd8e6b8bL326]
explain the problem?
{code}
lib/js/Gruntfile.js:
- grunt.registerTask('default', ['test', 'concat', 'uglify', 'jsdoc']);
+ grunt.registerTask('default', ['test', 'concat', 'uglify']);
{code}
> Misc CMake improvements
> -----------------------
>
> Key: THRIFT-5109
> URL: https://issues.apache.org/jira/browse/THRIFT-5109
> Project: Thrift
> Issue Type: Improvement
> Components: Build Process
> Reporter: Jens Geyer
> Assignee: Mario Emmenlauer
> Priority: Major
> Fix For: 0.14.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> * compiler/cpp/CMakeLists.txt: Install compiler after build, like automake
> does
> * Added NodeJS to cmake build
> * Added Javascript to cmake build
> * build/cmake/DefineInstallationPaths.cmake: fixed the library path
> * build/cmake/ThriftMacros.cmake: do not enforce debug suffix 'd'
> * lib/java/CMakeLists.txt: allow to override JAVA_INSTALL_DIR
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
