[
https://issues.apache.org/jira/browse/THRIFT-2877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17368473#comment-17368473
]
Roshan George commented on THRIFT-2877:
---------------------------------------
Ah, you're Java-serializing the class, hmm. I don't believe that the
compatibility guarantees act on that protocol (the Thrift objects are intended
to be serialized to data, the classes are helper accessors and not compatible
across versions when Java-serialized), but perhaps one of the maintainers will
have an opinion?
One thing I can think of is you using the new `TBaseHelper` and placing it in
front on the class path there.
> Optimize generated hashCode
> ---------------------------
>
> Key: THRIFT-2877
> URL: https://issues.apache.org/jira/browse/THRIFT-2877
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Compiler
> Affects Versions: 0.9.3
> Reporter: Mike Rettig
> Assignee: Roshan George
> Priority: Critical
> Fix For: 0.10.0
>
>
> The generated java hashCode method allocates an ArrayList then appends the
> fields to the list. Primitive fields will be boxed when added to the list.
> The generated code shouldn't allocate a list or box primitives. The hashCode
> can be calculated by using a primitive int and some static utility methods
> which can return the hashCode for each type.
> out << indent() << "@Override" << endl << indent() << "public int hashCode()
> {" << endl;
> 1839 indent_up();
> 1840 indent(out) << "List<Object> list = new ArrayList<Object>();" << endl;
> 1841
> 1842 for (m_iter = members.begin(); m_iter != members.end(); ++m_iter) {
> 1843 out << endl;
> 1844
> 1845 t_type* t = get_true_type((*m_iter)->get_type());
> 1846 bool is_optional = (*m_iter)->get_req() == t_field::T_OPTIONAL;
> 1847 bool can_be_null = type_can_be_null(t);
> 1848 string name = (*m_iter)->get_name();
> 1849
> 1850 string present = "true";
> 1851
> 1852 if (is_optional || can_be_null) {
> 1853 present += " && (" + generate_isset_check(*m_iter) + ")";
> 1854 }
> 1855
> 1856 indent(out) << "boolean present_" << name << " = " << present << ";"
> << endl;
> 1857 indent(out) << "list.add(present_" << name << ");" << endl;
> 1858 indent(out) << "if (present_" << name << ")" << endl;
> 1859 if (t->is_enum()) {
> 1860 indent(out) << " list.add(" << name << ".getValue());" << endl;
> 1861 } else {
> 1862 indent(out) << " list.add(" << name << ");" << endl;
> 1863 }
> 1864 }
> 1865
> 1866 out << endl;
> 1867 indent(out) << "return list.hashCode();" << endl;
> 1868 indent_down();
> 1869 indent(out) << "}" << endl << endl;
> 1870 }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
