[
https://issues.apache.org/jira/browse/THRIFT-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850913#comment-17850913
]
Carel commented on THRIFT-5773:
-------------------------------
[~Triton] [~jensg]
Any feedback on this?
I am still not sure how to handle migration and interop for people (like us)
using boost::uuid without introducing a public boost header dependency.
I did think of perhaps a compile option/preprocessor directive/macro to allow
one to disable or enable such a 'feature' if one already use boost.
Like
{code:java}
...
#ifdef THRIFT_CPP_USE_BOOST_UUID
#include <boost/uuid/uuid.hpp>
#ifdef THRIFT_CPP_USE_BOOST_UUID
class TUuid {
public:
...
#ifdef THRIFT_CPP_USE_BOOST_UUID
TUuid(const boost::uuids::uuid& str) noexcept;
#endif
};
{code}
It would be a lot better to use compared to what is tested
[here|https://github.com/apache/thrift/pull/2958/files#diff-0d60da734ee2049e698b3469df0d853411e95a32f0af18bbca20335066d178bdR130]
{code}
std::copy(std::begin(boost_uuid), std::end(boost_uuid), uuid.begin());
{code}
How would such a macro be received?
> UUID wrapper for C++
> --------------------
>
> Key: THRIFT-5773
> URL: https://issues.apache.org/jira/browse/THRIFT-5773
> Project: Thrift
> Issue Type: New Feature
> Reporter: Carel
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Continuation of THRIFT-5772
> Add a strong wrapper type for UUID support in C++
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
