[ https://issues.apache.org/jira/browse/THRIFT-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853533#comment-17853533 ]
Carel edited comment on THRIFT-5773 at 6/9/24 7:48 PM: ------------------------------------------------------- [~Triton] Thanks for your feedback. See my latest commits on my PR, I have added a preprocessor directive for Boost uuid support. Since this is a header only 'feature' one does not need to compile the thrift library with the definition, it is only required to be set when using the feature. I made two unit test applications, one that defines it on the project level and one that defines it in the file that includes the header, both pass and show how it can be used. Any feedback will be appreciated. [~jensg] Please consider this PR for inclusion before the next release. was (Author: JIRAUSER304590): [~Triton] Thanks for your feedback. See my latest comments on my PR, I have added a preprocessor directive for Boost uuid support. Since this is a header only 'feature' one does not need to compile the thrift library with the definition, it is only required to be set when using the feature. I made two unit test applications, one that defines it on the project level and one that defines it in the file that includes the header, both pass and show how it can be used. Any feedback will be appreciated. [~jensg] Please consider this PR for inclusion before the next release. > UUID wrapper for C++ > -------------------- > > Key: THRIFT-5773 > URL: https://issues.apache.org/jira/browse/THRIFT-5773 > Project: Thrift > Issue Type: New Feature > Reporter: Carel > Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Continuation of THRIFT-5772 > Add a strong wrapper type for UUID support in C++ -- This message was sent by Atlassian Jira (v8.20.10#820010)