[
https://issues.apache.org/jira/browse/THRIFT-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853749#comment-17853749
]
Triton Circonflexe edited comment on THRIFT-5773 at 6/10/24 5:24 PM:
---------------------------------------------------------------------
You’re right [~cjcombrink], there’s no need to adapt the build system since
it’s header-only.
Would it be possible to add some documentation about the feature? I think
{{lib/cpp/README.md}} is the right file for that given the current sections in
it.
Also, regarding your comment on the {{operator=(const std::string& str)}} part,
I’d say that it’s not necessary to include it and that the constructor is
enough (given that the feature is brand new in Thrift, I don’t think there is
too much of compatibility issue as the {{.thrift}} files would loose
compatibility anyway so a proper refactoring would be needed in any case).
My 2 cents.
was (Author: triton):
You’re right [~cjcombrink], there’s no need to adapt the build system since
it’s header-only.
Would it be possible to add some documentation about the feature? I think
{{lib/cpp/README.md}} is the right file for that given the current sections in
it.
Also, regarding your comment on the {{operator=(const std::string& str)}} part,
I’d say that it’s not necessary to include it and that the constructor is
enough (given that the feature is brand new in Thrift, I don’t think there is
too much of compatibility issue as the {{.thrift}} files would loose
compatibility anyway so a proper refactoring would be needed in any case.
My 2 cents.
> UUID wrapper for C++
> --------------------
>
> Key: THRIFT-5773
> URL: https://issues.apache.org/jira/browse/THRIFT-5773
> Project: Thrift
> Issue Type: New Feature
> Reporter: Carel
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Continuation of THRIFT-5772
> Add a strong wrapper type for UUID support in C++
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
