Hi,
Re: https://github.com/apache/thrift/pull/3144
This message is just to state the "it does not work on my machine" part of
the PR.
> If you need help with this, we can continue that topic at the user or dev
mailng list.
I have recreated the container and re-started the build from the current
master branch:
```
> git log -n 1
commit 1b8a998b938e5d21665d445f2e52ba9186c8ec4d (HEAD -> master,
origin/master, origin/HEAD)
Author: Yuxuan 'fishy' Wang <yuxuan.w...@reddit.com>
Date: Wed May 21 10:47:40 2025 -0700
> docker build --build-arg uid=$(id -u) --build-arg gid=$(id -g) -t
thrift-jammy build/docker/ubuntu-jammy
> docker run -v $(pwd):/thrift/src -it thrift-jammy /bin/bash
build@45f4d98f9c85:/thrift/src$ ./build/docker/scripts/cross-test.sh
```
d error:
```
make[3]: Entering directory '/thrift/src/lib/d/test'
dmd -L-fuse-ld=gold -L-levent ../libthriftd-event.a -L-fuse-ld=gold -L-lssl
-L-lcrypto ../libthriftd-ssl.a -w -wi -O -release -inline
-I../../../lib/d/src -Igen-d ../../../lib/d/libthriftd.a -ofasync_test
async_test.d
../libthriftd-ssl.a(ssl_347_3db.o):src/thrift/internal/ssl.d:function
_D6thrift8internal3ssl9authorizeFPS6deimos7opensslQBg6ssl_stCQCh9transportQCe14TAccessManagerC3std6socket7AddressLAyaZv:
error: undefined reference to 'SSL_get_peer_certificate'
../libthriftd-ssl.a(ssl_bio_34b_356.o):src/thrift/internal/ssl_bio.d:function
_D6thrift8internal7ssl_bio8setErrorFNbC9ExceptionZv: error: undefined
reference to 'ERR_put_error'
collect2: error: ld returned 1 exit status
```
The lisp error:
```
Unhandled TYPE-ERROR in thread #<SB-THREAD:THREAD "main thread" RUNNING
{10005205B3}>:
The value
NIL
is not of type
(OR (VECTOR CHARACTER) (VECTOR NIL) BASE-STRING PATHNAME SYNONYM-STREAM
FILE-STREAM)
when binding PATHNAME
Backtrace for: #<SB-THREAD:THREAD "main thread" RUNNING {10005205B3}>
0: (PATHNAME-NAME NIL) [more]
1: ((LAMBDA NIL :IN ASDF/FIND-SYSTEM:LOAD-ASD))
2: (ASDF/SESSION:CALL-WITH-ASDF-SESSION #<CLOSURE (LAMBDA NIL :IN
ASDF/FIND-SYSTEM:LOAD-ASD) {1003B9AE7B}> :OVERRIDE NIL :KEY NIL
:OVERRIDE-CACHE NIL :OVERRIDE-FORCING NIL)
3: (SB-INT:SIMPLE-EVAL-IN-LEXENV (ASDF/FIND-SYSTEM:LOAD-ASD (FIRST
(DIRECTORY (MERGE-PATHNAMES
"../../lib/cl/externals/software/clon-*/termio/net.didierverna.clon.termio.asd"
*LOAD-TRUENAME*)))) #<NULL-LEXENV>)
4: (EVAL-TLF (ASDF/FIND-SYSTEM:LOAD-ASD (FIRST (DIRECTORY (MERGE-PATHNAMES
"../../lib/cl/externals/software/clon-*/termio/net.didierverna.clon.termio.asd"
*LOAD-TRUENAME*)))) 4 NIL)
5: ((LABELS SB-FASL::EVAL-FORM :IN SB-INT:LOAD-AS-SOURCE)
(ASDF/FIND-SYSTEM:LOAD-ASD (FIRST (DIRECTORY (MERGE-PATHNAMES
"../../lib/cl/externals/software/clon-*/termio/net.didierverna.clon.termio.asd"
*LOAD-TRUENAME*)))) 4)
6: ((LAMBDA (SB-KERNEL:FORM &KEY :CURRENT-INDEX &ALLOW-OTHER-KEYS) :IN
SB-INT:LOAD-AS-SOURCE) (ASDF/FIND-SYSTEM:LOAD-ASD (FIRST (DIRECTORY
(MERGE-PATHNAMES
"../../lib/cl/externals/software/clon-*/termio/net.didierverna.clon.termio.asd"
*LOAD-TRUENAME*)))) :CURRENT-INDEX 4)
7: (SB-C::%DO-FORMS-FROM-INFO #<CLOSURE (LAMBDA (SB-KERNEL:FORM &KEY
:CURRENT-INDEX &ALLOW-OTHER-KEYS) :IN SB-INT:LOAD-AS-SOURCE) {100155D59B}>
#<SB-C::SOURCE-INFO {100155D553}> SB-C::INPUT-ERROR-IN-LOAD)
8: (SB-INT:LOAD-AS-SOURCE #<SB-SYS:FD-STREAM for "file
/thrift/src/test/cl/make-test-server.lisp" {100154E873}> :VERBOSE NIL
:PRINT NIL :CONTEXT "loading")
9: ((FLET SB-FASL::THUNK :IN LOAD))
10: (SB-FASL::CALL-WITH-LOAD-BINDINGS #<CLOSURE (FLET SB-FASL::THUNK :IN
LOAD) {7F3202D8F69B}> #<SB-SYS:FD-STREAM for "file
/thrift/src/test/cl/make-test-server.lisp" {100154E873}>)
11: ((FLET SB-FASL::LOAD-STREAM :IN LOAD) #<SB-SYS:FD-STREAM for "file
/thrift/src/test/cl/make-test-server.lisp" {100154E873}> NIL)
12: (LOAD #<SB-SYS:FD-STREAM for "file
/thrift/src/test/cl/make-test-server.lisp" {100154E873}> :VERBOSE NIL
:PRINT NIL :IF-DOES-NOT-EXIST T :EXTERNAL-FORMAT :DEFAULT)
13: ((FLET SB-IMPL::LOAD-SCRIPT :IN SB-IMPL::PROCESS-SCRIPT)
#<SB-SYS:FD-STREAM for "file /thrift/src/test/cl/make-test-server.lisp"
{100154E873}>)
14: ((FLET SB-UNIX::BODY :IN SB-IMPL::PROCESS-SCRIPT))
15: ((FLET "WITHOUT-INTERRUPTS-BODY-2" :IN SB-IMPL::PROCESS-SCRIPT))
16: (SB-IMPL::PROCESS-SCRIPT "make-test-server.lisp")
17: (SB-IMPL::TOPLEVEL-INIT)
18: ((FLET SB-UNIX::BODY :IN SAVE-LISP-AND-DIE))
19: ((FLET "WITHOUT-INTERRUPTS-BODY-7" :IN SAVE-LISP-AND-DIE))
20: ((LABELS SB-IMPL::RESTART-LISP :IN SAVE-LISP-AND-DIE))
```
Dart error:
```
cd test_client; /usr/lib/dart/bin/pub get
Resolving dependencies...
The current Dart SDK version is 2.7.2.
Because thrift_test_client depends on http >=0.13.0-nullsafety.0 which
requires SDK version >=2.12.0-0 <3.0.0 or >=3.0.0 <4.0.0, version solving
failed.
make[2]: *** [Makefile:635: pub-get] Error 1
```
C++ error (the fix for this is part of my PR)
```
src/TestServer.cpp:135:8: error: 'void
TestHandler::testUuid(apache::thrift::TUuid&, const
apache::thrift::TUuid&)' marked 'override', but does not override
135 | void testUuid(apache::thrift::TUuid& _return, const
apache::thrift::TUuid& thing) override {
| ^~~~~~~~
src/TestServer.cpp:450:8: error: 'void
TestHandlerAsync::testUuid(std::function<void(const
apache::thrift::TUuid&)>, const apache::thrift::TUuid&)' marked 'override',
but does not override
450 | void testUuid(::std::function<void(apache::thrift::TUuid const&
_return)> cob, const apache::thrift::TUuid& thing) override {
| ^~~~~~~~
```
(fixed by calling `sed -i 's|v0.16/||g' test/cpp/Makefile.am`)
PS: I have used the following command at each step to get the error, then
updated the configure to disable the specific language and rerun the
command, ensuring a clean build for each iteration (I have a fast machine
at my disposal)
```
build@9fafe21a1973:/thrift/src$ git clean -fdx && ./bootstrap.sh &&
./configure --enable-tutorial=no [--with-cl=no] [--with-dart=no]
[--with-d=no] && make -j3 precross; make precross
```
I am not committed to make progress past these errors, but since it was
brought up in the PR I just wanted to state/elaborate them. I have gotten
to a point where I could do what I needed without these languages.
I will be happy to engage further on this if and when I have time (outside
of my normal working hours)
Regards,
Carel
