Sorry, my attachment did not come through the last message, so I published my full build log at Gists:
https://gist.github.com/uilianries/64daa929828660cae9b09d0fd61ed47c Regards! On Fri, Oct 31, 2025 at 8:48 AM Uilian Ries <[email protected]> wrote: > Hello! > > > I think the issue is not why someone else needs it, the issue when > looking > at the compiler error (my interpretation at least) is that thrift itself > can't build as a shared lib if that field is not exported: > > That's correct. > The decision of exporting or not a function from Thrift is not a concern. > I understand devs have a motivation, but the Windows build is now broken > when trying to use CMake with shared libraries. > > I've attached a full build log on Windows that illustrates the case. > > What do you think? > > On Thu, Oct 30, 2025 at 9:03 PM Carel Combrink <[email protected]> > wrote: > >> Hi Jens, >> >> >> The other interesting question is, why it could be an issue at all, to >> keep >> > a private field private? >> >> >> I think the issue is not why someone else needs it, the issue when looking >> at the compiler error (my interpretation at least) is that thrift itself >> can't build as a shared lib if that field is not exported: >> >> > C:\j\b\thrif937bd10a672f8\b\build\bin\Release\thriftnbmd.dll : fatal >> error LNK1120: 1 unresolved externals >> [C:\j\b\thrif937bd10a672f8\b\build\lib\cpp\thriftnb.vcxproj] >> > Building Custom Rule >> C:/j/b/thrif937bd10a672f8/b/src/lib/cpp/CMakeLists.txt >> >> My 2c, >> >> Regards, >> Carel >> > > > -- > Cordialmente, > > Uilian Ries > <[email protected]> >
