Hi,

> that thrift itself can't build as a shared lib if that field is not exported:

Would it make sense to add some automated tests in that regard? If we support it, we should test it, to detect such kind of issues early, not 6 months after.

So if the consensus now is that we should do it, send a PR to export this specific symbol again. Someone will take care.

Have fun, JensG

Am 30.10.2025 um 21:03 schrieb Carel Combrink:
Hi Jens,


The other interesting question is, why it could be an issue at all, to keep
a private field private?

I think the issue is not why someone else needs it, the issue when looking
at the compiler error (my interpretation at least) is that thrift itself
can't build as a shared lib if that field is not exported:

  C:\j\b\thrif937bd10a672f8\b\build\bin\Release\thriftnbmd.dll : fatal
error LNK1120: 1 unresolved externals
[C:\j\b\thrif937bd10a672f8\b\build\lib\cpp\thriftnb.vcxproj]
   Building Custom Rule
C:/j/b/thrif937bd10a672f8/b/src/lib/cpp/CMakeLists.txt

My 2c,

Regards,
Carel

Reply via email to