[ 
https://issues.apache.org/jira/browse/TIKA-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178637#comment-13178637
 ] 

Nick Burch commented on TIKA-838:
---------------------------------

This breaks the CLIRR check, so I'll have to defer to someone else on the right 
solution for this patch
                
> EmptyParser Singleton should be final
> -------------------------------------
>
>                 Key: TIKA-838
>                 URL: https://issues.apache.org/jira/browse/TIKA-838
>             Project: Tika
>          Issue Type: Sub-task
>          Components: general
>            Reporter: Fabian Lange
>         Attachments: EmptyParser.java.patch
>
>
> Currently the Singleton EmptyParser is not a robust singleton. Other Code 
> could possibly exchange it, as it is not marked final.
> This might pose a security risk.
> Additionally, because the value is not final, the JVM cannot optimize it.
> Attached patch adds the final attribute.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to