[
https://issues.apache.org/jira/browse/TIKA-838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jukka Zitting resolved TIKA-838.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.1
Assignee: Jukka Zitting
I suppose in this case it's fine for us to break strict binary backwards
compatiblity, as no sane client should be modifying EmptyParser.INSTANCE in the
first place.
Thus I committed the patch in revision 1226904 with an exclude setting to make
clirr ignore the EmptyParser class.
Resolving as fixed. Thanks!
> EmptyParser Singleton should be final
> -------------------------------------
>
> Key: TIKA-838
> URL: https://issues.apache.org/jira/browse/TIKA-838
> Project: Tika
> Issue Type: Sub-task
> Components: general
> Reporter: Fabian Lange
> Assignee: Jukka Zitting
> Fix For: 1.1
>
> Attachments: EmptyParser.java.patch
>
>
> Currently the Singleton EmptyParser is not a robust singleton. Other Code
> could possibly exchange it, as it is not marked final.
> This might pose a security risk.
> Additionally, because the value is not final, the JVM cannot optimize it.
> Attached patch adds the final attribute.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
