OK, Thanks Chris. I committed, and also re-enabled those two @Overrides to make sure it "really" worked :)
Mike McCandless http://blog.mikemccandless.com On Tue, Feb 12, 2013 at 11:30 AM, Mattmann, Chris A (388J) <chris.a.mattm...@jpl.nasa.gov> wrote: > Mike, you could have fooled me! > > +1 to commit it, we're good. I think there haven't been any objections and > the discussion has sort of died down. > > Let's commit it! > > Cheers, > Chris > > > On 2/12/13 3:15 AM, "Michael McCandless" <luc...@mikemccandless.com> wrote: > >>Seems like this passes? >> >>Is this just a matter of changing tika-parent/pom.xml from: >> >> <properties> >> <maven.compile.source>1.5</maven.compile.source> >> <maven.compile.target>1.5</maven.compile.target> >> >><project.reporting.outputEncoding>${project.build.sourceEncoding}</project >>.reporting.outputEncoding> >> </properties> >> >>to: >> >> <properties> >> <maven.compile.source>1.6</maven.compile.source> >> <maven.compile.target>1.6</maven.compile.target> >> >><project.reporting.outputEncoding>${project.build.sourceEncoding}</project >>.reporting.outputEncoding> >> </properties> >> >>? >> >>I have precious little Maven experience... >> >>Mike McCandless >> >>http://blog.mikemccandless.com >> >>On Sat, Feb 9, 2013 at 9:52 AM, Dave Meikle <loo...@gmail.com> wrote: >>> +1 from me. >>> >>> Cheers, >>> Dave >>> >>> On 8 Feb 2013, at 17:49, Michael McCandless <luc...@mikemccandless.com> >>>wrote: >>> >>>> +1 >>>> >>>> Mike McCandless >>>> >>>> http://blog.mikemccandless.com >>>> >>>> >>>> >>>> On Fri, Feb 8, 2013 at 12:33 PM, Oleg Tikhonov <o...@apache.org> wrote: >>>>> Back to the "future". Aha moment !!! >>>>> Here is mine +1. >>>>> >>>>> According to Oracle "In February 2011 Oracle announced the End of >>>>>Public >>>>> Updates for their Java SE 6 products for July 2012. In February 2012 >>>>>Oracle >>>>> extended the End of Public Updates for 4 months, to November 2012. ". >>>>> >>>>> Oleg >>>>> >>>>> >>>>> >>>>> On Fri, Feb 8, 2013 at 6:54 PM, Mattmann, Chris A (388J) < >>>>> chris.a.mattm...@jpl.nasa.gov> wrote: >>>>> >>>>>> Hey Guys, >>>>>> >>>>>> Just to summarize, the question on the table is whether or not Tika >>>>>>should >>>>>> require Java6. We had some discussions on this previously (if I get >>>>>>time, >>>>>> will dig up the threads -- ok found time ;) ): >>>>>> >>>>>> https://issues.apache.org/jira/browse/TIKA-888 >>>>>> >>>>>> >>>>>>http://mail-archives.apache.org/mod_mbox/tika-dev/201011.mbox/%3CC8F38 >>>>>>B50.2 >>>>>> 3828%25chris.a.mattm...@jpl.nasa.gov%3E >>>>>> >>>>>> >>>>>> I'm +1 for it. Seems like so is Mike, and also Ken K. Any objections >>>>>>from >>>>>> others to require Java6? >>>>>> >>>>>> Cheers, >>>>>> Chris >>>>>> >>>>>> >>>>>> On 2/8/13 6:32 AM, "Ken Krugler" <kkrugler_li...@transpac.com> wrote: >>>>>> >>>>>>> >>>>>>> On Feb 8, 2013, at 3:54am, Michael McCandless wrote: >>>>>>> >>>>>>>> On Thu, Feb 7, 2013 at 3:51 PM, Nick Burch <apa...@gagravarr.org> >>>>>> wrote: >>>>>>>>> On Thu, 7 Feb 2013, Michael McCandless wrote: >>>>>>>>>> >>>>>>>>>> Hmm it looks like the Tika build is failing on Jenkins due to >>>>>>>>>>this: >>>>>>>>>> >>>>>>>>>> [ERROR] >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>/home/jenkins/jenkins-slave/workspace/Tika-trunk/trunk/tika-server >>>>>>>>>>/src/ >>>>>>>>>> main/java/org/apache/tika/server/CSVMessageBodyWriter.java:[51,3] >>>>>>>>>> method does not override a method from its superclass >>>>>>>>>> [ERROR] >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>/home/jenkins/jenkins-slave/workspace/Tika-trunk/trunk/tika-server >>>>>>>>>>/src/ >>>>>>>>>> >>>>>>>>>>main/java/org/apache/tika/server/JSONMessageBodyWriter.java:[51,3] >>>>>>>>>> method does not override a method from its superclass >>>>>>>>> >>>>>>>>> >>>>>>>>> Is that an @Override of a method from an Interface? That works on >>>>>>>>>JDK >>>>>>>>> 1.6+, >>>>>>>>> but isn't valid on JDK 1.5. Just remove the @Override from the >>>>>>>>> interface >>>>>>>>> implementing methods and you should be fine >>>>>>>> >>>>>>>> Ahh.... that's right. I had forgotten about this. I commented out >>>>>>>> those two @Overrides ... >>>>>>>> >>>>>>>> Maybe ... it's time for Tika to require Java 1.6? Java 1.6 is end >>>>>>>>of >>>>>>>> life next month after all Š >>>>>>> >>>>>>> +1 >>>>>>> >>>>>>> Seems like being one generation behind is OK, but not two :) >>>>>>> >>>>>>> -- Ken >>>>>>> >>>>>>> -------------------------- >>>>>>> Ken Krugler >>>>>>> +1 530-210-6378 >>>>>>> http://www.scaleunlimited.com >>>>>>> custom big data solutions & training >>>>>>> Hadoop, Cascading, Cassandra & Solr >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> >>> >
