----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22246/#review44773 -----------------------------------------------------------
The Matlab MIME types used seem to be application/x-matlab-data or application/matlab-mat. Would it make sense to add them to the mime XML for detection? <mime-type type="application/x-matlab-data"> <comment>MATLAB data file</comment> <alias type="application/matlab-mat"/> <magic priority="50"> <match value="MATLAB" type="string" offset="0"/> </magic> <glob pattern="*.mat"/> </mime-type> - Matthias Krueger On June 4, 2014, 10:23 p.m., Ann Burgess wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22246/ > ----------------------------------------------------------- > > (Updated June 4, 2014, 10:23 p.m.) > > > Review request for tika and Chris Mattmann. > > > Repository: tika > > > Description > ------- > > This is a new parser for Matlab .mat files. The parser utilizes the JmatIO, > Matlab's MAT-file I/O API in JAVA. JmatIO is available through Maven Central. > The text output from this parser provides variable names and dimensions that > are both inside and outside of data structures, but does NOT provide the > actual data values within each .mat file. > > > Diffs > ----- > > > Diff: https://reviews.apache.org/r/22246/diff/ > > > Testing > ------- > > Successfully run a basic unit test that checks both --text and --metadata > parser output. > > > File Attachments > ---------------- > > Parser File > > https://reviews.apache.org/media/uploaded/files/2014/06/04/cb39636d-ec53-4fbc-b348-6a4db8907f6b__MatParser.java > Unit Test > > https://reviews.apache.org/media/uploaded/files/2014/06/04/bbff8c6b-caa1-4830-b441-532c28c3c78e__MatParserTest.java > > > Thanks, > > Ann Burgess > >