----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22246/#review45019 -----------------------------------------------------------
One more step for making the diff -- you have to run `svn add [file]` on all of the new files (the Parser and ParserTest). That way, they will be incorporated into the diff. When you run `svn status`, files with a '?' entry will not be in the diff, but ones with an 'A' will (along with the already-existing-but-modified 'M' files). - Tyler Palsulich On June 6, 2014, 11:07 p.m., Ann Burgess wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22246/ > ----------------------------------------------------------- > > (Updated June 6, 2014, 11:07 p.m.) > > > Review request for tika and Chris Mattmann. > > > Repository: tika > > > Description > ------- > > This is a new parser for Matlab .mat files. The parser utilizes the JmatIO, > Matlab's MAT-file I/O API in JAVA. JmatIO is available through Maven Central. > The text output from this parser provides variable names and dimensions that > are both inside and outside of data structures, but does NOT provide the > actual data values within each .mat file. > > > Diffs > ----- > > > Diff: https://reviews.apache.org/r/22246/diff/ > > > Testing > ------- > > Successfully run a basic unit test that checks both --text and --metadata > parser output. > > > File Attachments > ---------------- > > TIKA-1327.aburgess.140606.patch.txt > > https://reviews.apache.org/media/uploaded/files/2014/06/06/3babeb42-6e15-4d31-ae7d-9dc7ef4c5f65__TIKA-1327.aburgess.140606.patch.txt > > > Thanks, > > Ann Burgess > >
