Hi all,
a guideline on how to handle existing code that does not adhere to 4
spaces would be helpful. When submitting a patch/pull request should I
include a commit reformatting the rest of the class if that's not
indented with 4 spaces?
Thanks
Matthias
On 14.07.2014 23:20, Mattmann, Chris A (3980) wrote:
Hey Nick, & Tyler,
I'm +1 in the 4 spaces (instead of tabs) - for the package imports,
I prefer explicit (no wildcard) imports, but I'm not sure that one is worth
trying to regulate.
Cheers,
Chris
-----Original Message-----
From: Tyler Palsulich <tpalsul...@gmail.com>
Reply-To: "dev@tika.apache.org" <dev@tika.apache.org>
Date: Monday, July 14, 2014 2:18 PM
To: "dev@tika.apache.org" <dev@tika.apache.org>
Subject: Re: Java code layout settings - do we have them documented
somewhere?
I think this would be very helpful. We could even describe how to update
these settings for a few editors/IDEs.
My vote is for 4 spaces in place of tabs and no wildcard imports. I
haven't
seen anything describing import preferences.
Tyler
On Jul 14, 2014 12:12 PM, "Nick Burch" <apa...@gagravarr.org> wrote:
Hi All
Recently when reviewing some patches from new contributors, we've had
some
confusion over spaces and tabs. For TIKA-1361, I've hit another one -
explicit imports vs package wide wildcard ones.
Currently, we don't seem to have anything listed on the Contributors
page
to tell people what we expect - http://tika.apache.org/contribute.html -
so they can't check. I'm happy to add something there, just need to know
what we've already decided so I know what to list!
For the spaces / tabs one, I've found TIKA-44 which concludes that we
should be using 4 spaces. Anything similar out there for imports?
Thanks
Nick
