[ 
https://issues.apache.org/jira/browse/TIKA-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130400#comment-15130400
 ] 

Tim Allison commented on TIKA-1848:
-----------------------------------

I tested adding headers, and they don't break our tests with the exception of 
test-tika-327 (where I had to put the license under the <?xml?> entity, and 
then it did work).

I'd prefer not to include license headers in our test files if we don't have 
to.  Happy to patch trunk if necessary, but would prefer to leave as is if 
possible.

> Address issues with Tika 1.12rc#1
> ---------------------------------
>
>                 Key: TIKA-1848
>                 URL: https://issues.apache.org/jira/browse/TIKA-1848
>             Project: Tika
>          Issue Type: Task
>    Affects Versions: 1.12
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>             Fix For: 1.12
>
>
> The following files for the 1.12rc#1 have unsuitable license headers
> {code}
>   /usr/local/drat/deploy/data/jobs/rat/1454458514778/input/testJAVA.java
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458508087/input/CharsetDetector.java
>   /usr/local/drat/deploy/data/jobs/rat/1454458508087/input/CharsetMatch.java
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458508087/input/CharsetRecog_2022.java
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458508087/input/CharsetRecog_UTF8.java
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458508087/input/CharsetRecog_Unicode.java
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458508087/input/CharsetRecog_mbcs.java
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458508087/input/CharsetRecog_sbcs.java
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458508087/input/CharsetRecognizer.java
>   /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/big-preamble.html
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/boilerplate-whitespace.html
>   /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/boilerplate.html
>   /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/resume.html
>   /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/test-tika-327.html
>   /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/test.html
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/testHTMLNoisyMetaEncoding_1.html
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/testHTMLNoisyMetaEncoding_2.html
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/testHTMLNoisyMetaEncoding_3.html
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/testHTMLNoisyMetaEncoding_4.html
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/testJsonMultipleInts.html
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/testlargerbuffer.html
>   /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/tika434.html
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to