[ 
https://issues.apache.org/jira/browse/TIKA-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130666#comment-15130666
 ] 

Ken Krugler commented on TIKA-1848:
-----------------------------------

Unless I'm not understanding the issues properly, I agree with the above - test 
files don't need license headers, and the character set detector code shouldn't 
get their existing (3rd party) license headers stomped on by us.

Don't know the relative value of DRAT vs RAT, and thus the value of figuring 
out how to leverage exclusions we've got so DRAT runs clean. Maybe modify this 
issue to be something like "Exclude test & 3rd party source files from DRAT 
analysis", lower the priority, and call it good for now?


> Address issues with Tika 1.12rc#1
> ---------------------------------
>
>                 Key: TIKA-1848
>                 URL: https://issues.apache.org/jira/browse/TIKA-1848
>             Project: Tika
>          Issue Type: Task
>    Affects Versions: 1.12
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>             Fix For: 1.12
>
>
> The following files for the 1.12rc#1 have unsuitable license headers
> {code}
>   /usr/local/drat/deploy/data/jobs/rat/1454458514778/input/testJAVA.java
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458508087/input/CharsetDetector.java
>   /usr/local/drat/deploy/data/jobs/rat/1454458508087/input/CharsetMatch.java
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458508087/input/CharsetRecog_2022.java
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458508087/input/CharsetRecog_UTF8.java
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458508087/input/CharsetRecog_Unicode.java
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458508087/input/CharsetRecog_mbcs.java
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458508087/input/CharsetRecog_sbcs.java
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458508087/input/CharsetRecognizer.java
>   /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/big-preamble.html
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/boilerplate-whitespace.html
>   /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/boilerplate.html
>   /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/resume.html
>   /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/test-tika-327.html
>   /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/test.html
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/testHTMLNoisyMetaEncoding_1.html
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/testHTMLNoisyMetaEncoding_2.html
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/testHTMLNoisyMetaEncoding_3.html
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/testHTMLNoisyMetaEncoding_4.html
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/testJsonMultipleInts.html
>   
> /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/testlargerbuffer.html
>   /usr/local/drat/deploy/data/jobs/rat/1454458515805/input/tika434.html
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to