[ 
https://issues.apache.org/jira/browse/TIKA-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15162977#comment-15162977
 ] 

ASF GitHub Bot commented on TIKA-1868:
--------------------------------------

GitHub user nhojpatrick opened a pull request:

    https://github.com/apache/tika/pull/76

    TIKA-1868 tika-server split into clean and standalone jar

    Understand based upon mailing email and jira defect this might be rejected.
    
    But this the change I was intending to do, my original email was to 
understand if tika-server meant to be a shaded jar, which it appears to was 
intended to be.
    
    But if you need to use classes that only live within tika-server it does 
make it harder to write custom code. If the guts of tika-server where put into 
another module maybe tika-server-internals then those that really need to used 
classes that just live in tika-server can use tika-server-internals and 
tika-server can be a simply shaded jar. Just a thought.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nhojpatrick/tika bugfix/TIKA-1868

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tika/pull/76.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #76
    
----
commit 9b106210fa8be284b47ab5b904dcf83b0f175308
Author: John Patrick <nhoj.patr...@gmail.com>
Date:   2016-02-24T12:33:56Z

    TIKA-1868 tika-server split into clean and standalone jar

----


> create clean tika-server jar and shaded classifier jar
> ------------------------------------------------------
>
>                 Key: TIKA-1868
>                 URL: https://issues.apache.org/jira/browse/TIKA-1868
>             Project: Tika
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 1.11, 1.12
>         Environment: n/a
>            Reporter: John Patrick
>              Labels: github-import, maven, newbie, patch
>             Fix For: 1.13
>
>
> If using tika-server-VERSION.jar as a standalone component it works. But if 
> you use it as a dependency so is included with other jars then it causes 
> classpath issues specifically around jackson.
> The project I'm working on is using Jackson 2.6.1, we have just added tika 
> but when adding tika-server-VERSION.jar we have discovered it contains 
> Jackson 2.4.0 classes.
> I've update the maven build so two jar's are now created.
> 1) tika-server-VERSION.jar correct clean jar
> 2) tika-server-VERSION-standalone.jar what was previously created
> This in my view is more inline with how maven should be being used to create 
> jars as the previous way restricted the consumers ability to override maven 
> dependencies.
> I've also updated the documentation in source control that refs to 
> tika-server to include the new tika-server standalone jar. I realize other 
> documentation might also need to change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to