[ 
https://issues.apache.org/jira/browse/TIKA-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730600#comment-17730600
 ] 

Tim Allison commented on TIKA-4062:
-----------------------------------

I merged 1179.  [~ravijha], if you can open a PR to add a unit test, that'd be 
great.  Thank you!

> OfflineContentHandler/ContentHandlerDecorator does not provide option for 
> custom error handling
> -----------------------------------------------------------------------------------------------
>
>                 Key: TIKA-4062
>                 URL: https://issues.apache.org/jira/browse/TIKA-4062
>             Project: Tika
>          Issue Type: Bug
>          Components: tika-core
>    Affects Versions: 2.3.0, 2.4.0, 2.5.0, 2.6.0, 2.7.0, 2.8.0
>            Reporter: Ravi Ranjan Jha
>            Priority: Critical
>
> OfflineContentHandler/ContentHandlerDecorator does not provide option for 
> custom error handling
> Prior to the change of passing OfflineContentHandler to SAX Parser in 
> XMLReaderUtils.parseSAX, one could pass a custom ContentHandlerDecorator to 
> handle exception or override error/warning etc methods. The same is not 
> possible now because the default impl for handleException in the 
> OfflineContentHandler's parent ContentHandlerDecorator just throws exception 
> as shown below:
>  
>  protected void handleException(SAXException exception) throws SAXException {
>         throw exception;
>     }
>  
> which could probably be (at minimum)
> public void handleException(SAXException exception) throws SAXException {
>         handler.handleException(exception);
>     }
>  
> This is breaking our app's behavior. Please take it as priority.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to