[ 
https://issues.apache.org/jira/browse/TIKA-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731752#comment-17731752
 ] 

Hudson commented on TIKA-4062:
------------------------------

SUCCESS: Integrated in Jenkins build Tika » tika-main-jdk11 #1111 (See 
[https://ci-builds.apache.org/job/Tika/job/tika-main-jdk11/1111/])
TIKA-4062: Test cases for custom error handling during XML parsing (#1186) 
(github: 
[https://github.com/apache/tika/commit/051ea7a3eb4125c64811ecb8db1d689b57082df0])
* (add) 
tika-core/src/test/java/org/apache/tika/sax/NonValidatingContentHandler.java
* (add) 
tika-core/src/test/java/org/apache/tika/sax/ErrorResistantSAXParserFactory.java
* (edit) tika-core/pom.xml
* (add) tika-core/src/test/java/org/apache/tika/sax/CustomErrorHandlerTest.java
* (add) tika-core/src/test/resources/test-documents/undeclared_entity.xml


> OfflineContentHandler/ContentHandlerDecorator does not provide option for 
> custom error handling
> -----------------------------------------------------------------------------------------------
>
>                 Key: TIKA-4062
>                 URL: https://issues.apache.org/jira/browse/TIKA-4062
>             Project: Tika
>          Issue Type: Bug
>          Components: tika-core
>    Affects Versions: 2.3.0, 2.4.0, 2.5.0, 2.6.0, 2.7.0, 2.8.0
>            Reporter: Ravi Ranjan Jha
>            Priority: Critical
>             Fix For: 2.8.1
>
>
> OfflineContentHandler/ContentHandlerDecorator does not provide option for 
> custom error handling
> Prior to the change of passing OfflineContentHandler to SAX Parser in 
> XMLReaderUtils.parseSAX, one could pass a custom ContentHandlerDecorator to 
> handle exception or override error/warning etc methods. The same is not 
> possible now because the default impl for handleException in the 
> OfflineContentHandler's parent ContentHandlerDecorator just throws exception 
> as shown below:
>  
>  protected void handleException(SAXException exception) throws SAXException {
>         throw exception;
>     }
>  
> which could probably be (at minimum)
> public void handleException(SAXException exception) throws SAXException {
>         handler.handleException(exception);
>     }
>  
> This is breaking our app's behavior. Please take it as priority.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to