LucaDai commented on PR #2360: URL: https://github.com/apache/tika/pull/2360#issuecomment-3384184751
> Thanks, I think I get the point. About style, I'd prefer to have a detectStream() that calls a detectString() instead of 1 method that has an object parameter. > > It turns out we have had contact with nondex before: [TIKA-3944](https://issues.apache.org/jira/browse/TIKA-3944) Thanks for reviewing my PR and providing suggestions! I updated the code, the Object is removed, `detectStream()` now calls `detectString()`. This should be cleaner and type-safe now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
