LucaDai commented on PR #2360: URL: https://github.com/apache/tika/pull/2360#issuecomment-3384503422
> Thanks, this is much better. More to do: 1) Create an issue in JIRA 2) rename the title of this PR to "[TIKA-XXXX](https://issues.apache.org/jira/browse/TIKA-XXXX): your text......" (replace XXXX with the number you got in step 1), 3) add a 1 line comment in the code with a text like "[TIKA-XXXX](https://issues.apache.org/jira/browse/TIKA-XXXX) @put and @post separately to avoid nondeterministic failures" (this is to avoid that in a few years someone refactors the code to make it shorter) 4) if you know how to do it, squash your commits and change the commit text so that it begins with [TIKA-XXXX](https://issues.apache.org/jira/browse/TIKA-XXXX) . Thanks a lot for the clear guidance! I’ve followed all the steps (JIRA issue, PR title, inline comment, and squashed commit). Could you please review it again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
