[
https://issues.apache.org/jira/browse/TIKA-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18071925#comment-18071925
]
ASF GitHub Bot commented on TIKA-4699:
--------------------------------------
tballison opened a new pull request, #2752:
URL: https://github.com/apache/tika/pull/2752
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for your contribution to [Apache Tika](https://tika.apache.org/)!
Your help is appreciated!
Before opening the pull request, please verify that
* there is an open issue on the [Tika issue
tracker](https://issues.apache.org/jira/projects/TIKA) which describes the
problem or the improvement. We cannot accept pull requests without an issue
because the change wouldn't be listed in the release notes.
* the issue ID (`TIKA-XXXX`)
- is referenced in the title of the pull request
- and placed in front of your commit messages surrounded by square
brackets (`[TIKA-XXXX] Issue or pull request title`)
* commits are squashed into a single one (or few commits for larger changes)
* Tika is successfully built and unit tests pass by running `./mvnw clean
test`
* there should be no conflicts when merging the pull request branch into the
*recent* `main` branch. If there are conflicts, please try to rebase the pull
request branch on top of a freshly pulled `main` branch
* if you add new module that downstream users will depend upon add it to
relevant group in `tika-bom/pom.xml`.
We will be able to faster integrate your pull request if these conditions
are met. If you have any questions how to fix your problem or about using Tika
in general, please sign up for the [Tika mailing
list](http://tika.apache.org/mail-lists.html). Thanks!
> Non optional import-package in org.apache.tika.bundle-standard:
> "com.github.javaparser.resolution"
> --------------------------------------------------------------------------------------------------
>
> Key: TIKA-4699
> URL: https://issues.apache.org/jira/browse/TIKA-4699
> Project: Tika
> Issue Type: Bug
> Components: build
> Affects Versions: 3.3.0
> Reporter: Konrad Windszus
> Priority: Major
>
> Currently lots of imports are marked optional in
> https://github.com/apache/tika/blob/a7e6ac73862d0d8d719ace8b9d0cb6d39efb926b/tika-bundles/tika-bundle-standard/pom.xml#L212-L337.
> Notably missing is {{com.github.javaparser.resolution}}.
> That prevents from using this bundle where this dependency is not provided
> through another bundle:
> {code}
> Unable to resolve org.apache.tika.bundle-standard [15](R 15.0): missing
> requirement [org.apache.tika.bundle-standard [15](R 15.0)]
> osgi.wiring.package; (osgi.wiring.package=com.github.javaparser.resolution)
> Unresolved requirements: [[org.apache.tika.bundle-standard [15](R 15.0)]
> osgi.wiring.package; (osgi.wiring.package=com.github.javaparser.resolution)]
> at
> org.apache.felix.framework.Felix.resolveBundleRevision(Felix.java:4398)
> at org.apache.felix.framework.Felix.startBundle(Felix.java:2308)
> at org.apache.felix.framework.Felix.setActiveStartLevel(Felix.java:1566)
> at
> org.apache.felix.framework.FrameworkStartLevelImpl.run(FrameworkStartLevelImpl.java:308)
> at java.base/java.lang.Thread.run(Thread.java:829)
> {code}
> It is unclear if really some packages of
> https://github.com/javaparser/javaparser are optional and others are
> mandatory or this is just bug in the generated manifest.
> If it is the latter instead of listing each package individually using a
> wildcard is supported to match the package and all its sub packages
> (https://bnd.bndtools.org/heads/import_package.html) is best practice in
> https://github.com/apache/tika/blob/a7e6ac73862d0d8d719ace8b9d0cb6d39efb926b/tika-bundles/tika-bundle-standard/pom.xml#L203
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
