[
https://issues.apache.org/jira/browse/TIKA-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18071933#comment-18071933
]
ASF GitHub Bot commented on TIKA-4699:
--------------------------------------
kwin commented on code in PR #2752:
URL: https://github.com/apache/tika/pull/2752#discussion_r3050868781
##########
tika-bundles/tika-bundle-standard/pom.xml:
##########
@@ -143,6 +143,10 @@
org.apache.tika.parser.internal.Activator
</Bundle-Activator>
<Embed-Dependency>*;scope=compile;artifactId=tika-parsers-standard-package|
Review Comment:
Looks better, I haven't tried to deploy in OSGi though yet.
> Non optional import-package in org.apache.tika.bundle-standard:
> "com.github.javaparser.resolution"
> --------------------------------------------------------------------------------------------------
>
> Key: TIKA-4699
> URL: https://issues.apache.org/jira/browse/TIKA-4699
> Project: Tika
> Issue Type: Bug
> Components: build
> Affects Versions: 3.3.0
> Reporter: Konrad Windszus
> Priority: Major
>
> Currently lots of imports are marked optional in
> https://github.com/apache/tika/blob/a7e6ac73862d0d8d719ace8b9d0cb6d39efb926b/tika-bundles/tika-bundle-standard/pom.xml#L212-L337.
> Notably missing is {{com.github.javaparser.resolution}}.
> That prevents from using this bundle where this dependency is not provided
> through another bundle:
> {code}
> Unable to resolve org.apache.tika.bundle-standard [15](R 15.0): missing
> requirement [org.apache.tika.bundle-standard [15](R 15.0)]
> osgi.wiring.package; (osgi.wiring.package=com.github.javaparser.resolution)
> Unresolved requirements: [[org.apache.tika.bundle-standard [15](R 15.0)]
> osgi.wiring.package; (osgi.wiring.package=com.github.javaparser.resolution)]
> at
> org.apache.felix.framework.Felix.resolveBundleRevision(Felix.java:4398)
> at org.apache.felix.framework.Felix.startBundle(Felix.java:2308)
> at org.apache.felix.framework.Felix.setActiveStartLevel(Felix.java:1566)
> at
> org.apache.felix.framework.FrameworkStartLevelImpl.run(FrameworkStartLevelImpl.java:308)
> at java.base/java.lang.Thread.run(Thread.java:829)
> {code}
> It is unclear if really some packages of
> https://github.com/javaparser/javaparser are optional and others are
> mandatory or this is just bug in the generated manifest.
> If it is the latter instead of listing each package individually using a
> wildcard is supported to match the package and all its sub packages
> (https://bnd.bndtools.org/heads/import_package.html) is best practice in
> https://github.com/apache/tika/blob/a7e6ac73862d0d8d719ace8b9d0cb6d39efb926b/tika-bundles/tika-bundle-standard/pom.xml#L203
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
