[
https://issues.apache.org/jira/browse/TIKA-4931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18119227#comment-18119227
]
ASF GitHub Bot commented on TIKA-4931:
--------------------------------------
tballison opened a new pull request, #3257:
URL: https://github.com/apache/tika/pull/3257
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for your contribution to [Apache Tika](https://tika.apache.org/)!
Your help is appreciated!
Before opening the pull request, please verify that
* there is an open issue on the [Tika issue
tracker](https://issues.apache.org/jira/projects/TIKA) which describes the
problem or the improvement. We cannot accept pull requests without an issue
because the change wouldn't be listed in the release notes.
* the issue ID (`TIKA-XXXX`)
- is referenced in the title of the pull request
- and placed in front of your commit messages surrounded by square
brackets (`[TIKA-XXXX] Issue or pull request title`)
* commits are squashed into a single one (or few commits for larger changes)
* Tika builds and unit tests pass with `./mvnw clean install` (`clean test`
alone cannot resolve the pipes plugin zips)
* if you used a generative AI tool: follow the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) (`Generated-by:
<tool>` in the commit message), and consider running the pre-flight in
`.skills/devs/pr-review/SKILL.md` — fix what it finds; don't paste its report
here
* there should be no conflicts when merging the pull request branch into the
*recent* `main` branch. If there are conflicts, please try to rebase the pull
request branch on top of a freshly pulled `main` branch
* if you add new module that downstream users will depend upon add it to
relevant group in `tika-bom/pom.xml`.
We will be able to faster integrate your pull request if these conditions
are met. If you have any questions how to fix your problem or about using Tika
in general, please sign up for the [Tika mailing
list](http://tika.apache.org/mail-lists.html). Thanks!
> PipesForkParser drops socketTimeoutMillis and javaPath set on
> PipesForkParserConfig
> -----------------------------------------------------------------------------------
>
> Key: TIKA-4931
> URL: https://issues.apache.org/jira/browse/TIKA-4931
> Project: Tika
> Issue Type: Task
> Reporter: Tim Allison
> Priority: Trivial
>
> From a :robot: :
> PipesForkParser writes its config to a JSON file with
> ConfigMerger.mergeOrCreate(), then loads it with PipesParser.load(path).
> ConfigOverrides.PipesConfigOverride only carries numClients,
> maxFilesProcessedPerProcess and forkedJvmArgs. Anything else set on
> PipesForkParserConfig.getPipesConfig() never reaches the file, including
> socketTimeoutMillis and javaPath (the latter set through
> setJavaPath).
> As a result, the fork runs java from the PATH instead of the configured
> path, and the socket timeout stays at the 60s default. There's no error or
> warning.
> Fix: carry socketTimeoutMillis and javaPath through ConfigOverrides and
> ConfigMerger, and review the other PipesConfig setters for the same gap. Add
> a round-trip test: set values on the config,
> build the parser, reload the merged file, and check they match.
> Found by [~dpol1] on apache/stormcrawler#2183.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
