[
https://issues.apache.org/jira/browse/TIKA-4931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18119513#comment-18119513
]
Hudson commented on TIKA-4931:
------------------------------
SUCCESS: Integrated in Jenkins build Tika » tika-main-jdk17 #1677 (See
[https://ci-builds.apache.org/job/Tika/job/tika-main-jdk17/1677/])
TIKA-4931: fix overrides in PipesForkParser (#3257) (github:
[https://github.com/apache/tika/commit/ebc845c390ab375722e3dd7e9b50b92cf88b99aa])
* (edit) CHANGES.txt
* (edit)
tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/config/ConfigOverrides.java
* (edit)
tika-pipes/tika-pipes-fork-parser/src/main/java/org/apache/tika/pipes/fork/PipesForkParser.java
* (edit)
tika-pipes/tika-pipes-fork-parser/src/test/java/org/apache/tika/pipes/fork/PipesForkParserTest.java
* (edit)
tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/config/ConfigMerger.java
* (edit)
tika-pipes/tika-pipes-core/src/test/java/org/apache/tika/pipes/core/config/ConfigMergerTest.java
* (edit)
tika-pipes/tika-pipes-fork-parser/src/main/java/org/apache/tika/pipes/fork/PipesForkParserConfig.java
> PipesForkParser drops socketTimeoutMillis and javaPath set on
> PipesForkParserConfig
> -----------------------------------------------------------------------------------
>
> Key: TIKA-4931
> URL: https://issues.apache.org/jira/browse/TIKA-4931
> Project: Tika
> Issue Type: Task
> Reporter: Tim Allison
> Priority: Trivial
> Fix For: 4.1.0
>
>
> From a :robot: :
> PipesForkParser writes its config to a JSON file with
> ConfigMerger.mergeOrCreate(), then loads it with PipesParser.load(path).
> ConfigOverrides.PipesConfigOverride only carries numClients,
> maxFilesProcessedPerProcess and forkedJvmArgs. Anything else set on
> PipesForkParserConfig.getPipesConfig() never reaches the file, including
> socketTimeoutMillis and javaPath (the latter set through
> setJavaPath).
> As a result, the fork runs java from the PATH instead of the configured
> path, and the socket timeout stays at the 60s default. There's no error or
> warning.
> Fix: carry socketTimeoutMillis and javaPath through ConfigOverrides and
> ConfigMerger, and review the other PipesConfig setters for the same gap. Add
> a round-trip test: set values on the config,
> build the parser, reload the merged file, and check they match.
> Found by [~dpol1] on apache/stormcrawler#2183.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
