[
https://issues.apache.org/jira/browse/TINKERPOP-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421066#comment-15421066
]
ASF GitHub Bot commented on TINKERPOP-1402:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/380
TINKERPOP-1402 Added IoBuilder.onMapper() method.
https://issues.apache.org/jira/browse/TINKERPOP-1402
Deprecated IoBuilder.registry() in the process of doing that. This should
provide greater flexibility to Graph providers who can now not only supply a
custom IoRegistry but also access other non-generalized features of a
Mapper.Builder instance.
Tested with `mvn clean install`. I did a one-time test before changing
TinkerGraph to stop using the deprecated `registry` method and the build worked
fine so I think that even though we can't directly test the old `registry`
method anymore, it still should be working ok if provides elect to stick with
it.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1402
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/380.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #380
----
commit f1617e202025db1ff6f94deb70c66f14772273bf
Author: Stephen Mallette <[email protected]>
Date: 2016-08-15T14:29:46Z
Added IoBuilder.onMapper() method.
Deprecated IoBuilder.registry() in the process of doing that. This should
provide greater flexibility to Graph providers who can now not only supply a
custom IoRegistry but also access other non-generalized features of a
Mapper.Builder instance.
----
> Impossible for graph implementations to provide a class resolver for Gryo IO
> ----------------------------------------------------------------------------
>
> Key: TINKERPOP-1402
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1402
> Project: TinkerPop
> Issue Type: Improvement
> Components: structure
> Affects Versions: 3.2.1
> Reporter: Bryn Cooke
> Priority: Critical
> Fix For: 3.2.2
>
>
> As far as I can tell there is no way for a graph implementation to specify a
> classresolver for the following code:
> {noformat}g.io(IoCore.gryo()).writer().create(){noformat}
> The problem is that inside the graph implementation we need to be able to do
> this:
> {noformat}
> public <I extends Io> I io(final Io.Builder<I> builder) {
> Io io =
> builder.graph(this).registry(MyRegistry.INSTANCE).classResolver(MyClassReolver.INSTANCE).create();
> {noformat}
> but only supplying a registry is supported.
> Other solutions could be to design GryoIo for extension so that it can be
> wrapped or to change the signature of Graph#io to:
> {noformat}
> public default Io io(final Io.Builder<I> builder)
> {noformat}
> I would probably go for the signature change, so the graph is responsible for
> deciding the implementation that is returned.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
