[ https://issues.apache.org/jira/browse/TINKERPOP-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422683#comment-15422683 ]
ASF GitHub Bot commented on TINKERPOP-1402: ------------------------------------------- Github user twilmes commented on the issue: https://github.com/apache/tinkerpop/pull/380 VOTE: +1 > Impossible for graph implementations to provide a class resolver for Gryo IO > ---------------------------------------------------------------------------- > > Key: TINKERPOP-1402 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1402 > Project: TinkerPop > Issue Type: Improvement > Components: structure > Affects Versions: 3.2.1 > Reporter: Bryn Cooke > Priority: Critical > Fix For: 3.2.2 > > > As far as I can tell there is no way for a graph implementation to specify a > classresolver for the following code: > {noformat}g.io(IoCore.gryo()).writer().create(){noformat} > The problem is that inside the graph implementation we need to be able to do > this: > {noformat} > public <I extends Io> I io(final Io.Builder<I> builder) { > Io io = > builder.graph(this).registry(MyRegistry.INSTANCE).classResolver(MyClassReolver.INSTANCE).create(); > {noformat} > but only supplying a registry is supported. > Other solutions could be to design GryoIo for extension so that it can be > wrapped or to change the signature of Graph#io to: > {noformat} > public default Io io(final Io.Builder<I> builder) > {noformat} > I would probably go for the signature change, so the graph is responsible for > deciding the implementation that is returned. -- This message was sent by Atlassian JIRA (v6.3.4#6332)