Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/384
  
    nice @robertdale - a final request from my end would be documentation. 
perhaps a word or two added to the docs about these settings. I guess the 
reference docs might be the best place for that:
    
    
https://github.com/apache/tinkerpop/blob/f35f733663029701af538fc527e1f5ab563eb07d/docs/src/reference/gremlin-applications.asciidoc#console-commands
    
    then maybe an announcement of the feature in upgrade docs for users:
    
    
https://github.com/apache/tinkerpop/blob/f35f733663029701af538fc527e1f5ab563eb07d/docs/src/upgrade/release-3.2.x-incubating.asciidoc#upgrading-for-users
    
    and if you want to really be complete an entry in changelog:
    
    
https://github.com/apache/tinkerpop/blob/f35f733663029701af538fc527e1f5ab563eb07d/CHANGELOG.asciidoc#tinkerpop-322-not-officially-released-yet
    
    @dkuppitz brought up the full scope of the ticket, but i think we can save 
the bigger picture for some other time. at least the pattern for colors is in 
place and working.
    
    I still haven't tested this out myself or reviewed the code just yet to see 
what you did differently than me to get this to work. My mind is still kinda 
reeling from that.  :disappointed: 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to