[
https://issues.apache.org/jira/browse/TINKERPOP-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552152#comment-15552152
]
ASF GitHub Bot commented on TINKERPOP-1458:
-------------------------------------------
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/451#discussion_r82210120
--- Diff:
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/remote/DriverRemoteTraversalSideEffects.java
---
@@ -89,9 +100,8 @@ public DriverRemoteTraversalSideEffects(final Client
client, final UUID serverSi
keys =
client.submitAsync(msg).get().all().get().stream().map(r ->
r.getString()).collect(Collectors.toSet());
--- End diff --
At first, I didn't like that this because it replaced the whole `Set` - if
you'd called `get()` first then this the set would get re-initialized when it
already had keys in it. But I suppose that's not really a problem. If you don't
do that then you have to check if the `Set` was initialized or not and if not
new one up:
```java
if (keys == Collections.emptySet())
keys = new HashSet<>();
client.submitAsync(msg).get().all().get().forEach(r ->
keys.add(r.getString())
````
A tad nicer because it gets rid of `stream()`....i dunno either way is fine
i guess.
> Gremlin Server doesn't return confirmation upon Traversal OpProcessor "close"
> op
> --------------------------------------------------------------------------------
>
> Key: TINKERPOP-1458
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1458
> Project: TinkerPop
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.2
> Reporter: David M. Brown
> Assignee: David M. Brown
> Fix For: 3.2.3
>
>
> Gremlin Server should return some sort of success message to driver upon
> invalidating the side effect cache for a traversal.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
