[
https://issues.apache.org/jira/browse/TINKERPOP-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552160#comment-15552160
]
ASF GitHub Bot commented on TINKERPOP-1458:
-------------------------------------------
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/451#discussion_r82210649
--- Diff:
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/remote/DriverRemoteTraversalSideEffects.java
---
@@ -89,9 +100,8 @@ public DriverRemoteTraversalSideEffects(final Client
client, final UUID serverSi
keys =
client.submitAsync(msg).get().all().get().stream().map(r ->
r.getString()).collect(Collectors.toSet());
} catch (Exception ex) {
final Throwable root = ExceptionUtils.getRootCause(ex);
- if (root.getMessage().equals("Could not find side-effects
for " + serverSideEffect + "."))
- keys = Collections.emptySet();
- else
+ final String exMsg = null == root ? "" : root.getMessage();
+ if (!exMsg.equals("Could not find side-effects for " +
serverSideEffect + "."))
--- End diff --
I know you didn't add this, but I really hate that we had to do this
message checking - need a JIRA ticket to improve this (or perhaps a comment on
an existing ticket regarding exceptions coming back from the server if there's
a relevant one like that).
> Gremlin Server doesn't return confirmation upon Traversal OpProcessor "close"
> op
> --------------------------------------------------------------------------------
>
> Key: TINKERPOP-1458
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1458
> Project: TinkerPop
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.2
> Reporter: David M. Brown
> Assignee: David M. Brown
> Fix For: 3.2.3
>
>
> Gremlin Server should return some sort of success message to driver upon
> invalidating the side effect cache for a traversal.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
