Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/451#discussion_r82211005
--- Diff:
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/remote/DriverRemoteTraversalSideEffects.java
---
@@ -39,12 +40,14 @@
public class DriverRemoteTraversalSideEffects extends
AbstractRemoteTraversalSideEffects {
private final Client client;
- private Set<String> keys = null;
+ private Set<String> keys = Collections.emptySet();
private final UUID serverSideEffect;
private final Host host;
private final Map<String, Object> sideEffects = new HashMap<>();
+ private boolean closed = false;
--- End diff --
I suppose it is ok that the close status isn't really thread safe. I guess
it would be weird for someone to make multi-threaded calls over the side-effect
object. That seems unusual. Just thought i'd point that out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
