Github user spmallette commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/451#discussion_r82210649
  
    --- Diff: 
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/remote/DriverRemoteTraversalSideEffects.java
 ---
    @@ -89,9 +100,8 @@ public DriverRemoteTraversalSideEffects(final Client 
client, final UUID serverSi
                     keys = 
client.submitAsync(msg).get().all().get().stream().map(r -> 
r.getString()).collect(Collectors.toSet());
                 } catch (Exception ex) {
                     final Throwable root = ExceptionUtils.getRootCause(ex);
    -                if (root.getMessage().equals("Could not find side-effects 
for " + serverSideEffect + "."))
    -                    keys = Collections.emptySet();
    -                else
    +                final String exMsg = null == root ? "" : root.getMessage();
    +                if (!exMsg.equals("Could not find side-effects for " + 
serverSideEffect + "."))
    --- End diff --
    
    I know you didn't add this, but I really hate that we had to do this 
message checking - need a JIRA ticket to improve this (or perhaps a comment on 
an existing ticket regarding exceptions coming back from the server if there's 
a relevant one like that).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to