[
https://issues.apache.org/jira/browse/TINKERPOP-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15618318#comment-15618318
]
ASF GitHub Bot commented on TINKERPOP-1493:
-------------------------------------------
Github user pluradj commented on the issue:
https://github.com/apache/tinkerpop/pull/457
I verified multiple platforms to ensure the changes didn't have any adverse
affects.
- On Docker, this builds cleanly with `docker/build.sh -t -n -i`
- On Mac, this builds cleanly with `mvn clean install
-DskipIntegrationTests=false`
- On Windows, this builds cleanly with `mvn clean install -DskipTests`.
Following it up with `mvn clean install -DskipIntegrationTests=true` succeeds
all the way through `hadoop-gremlin`, and then previously witnessed build
failures on Windows start occurring in `spark-gremlin`. Skipping past
`spark-gremlin` and `giraph-gremlin`, this builds cleanly to completion with
`mvn clean install -DskipIntegrationTests=true -DincludeNeo4j -rf
:neo4j-gremlin`.
Code changes look good to me.
VOTE: +1
> Groovy project doesn't build on Windows
> ---------------------------------------
>
> Key: TINKERPOP-1493
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1493
> Project: TinkerPop
> Issue Type: Bug
> Components: groovy
> Affects Versions: 3.2.2
> Reporter: Paul Jackson
> Priority: Minor
>
> Builds on Windows fail for two reasons. First the line to create extTestDir
> is creating a path consisting of two full paths concatenated together. The
> second drive letter is seen as an illegal character:
> {code}private static final File extTestDir = new
> File(System.getProperty("user.dir"),
> TestHelper.makeTestDataDirectory(DependencyGrabberTest.class));{code}
> Second, when it comes time to delete the directory it is locked. This is
> because some instances of JarFile are created on it but not closed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
