[
https://issues.apache.org/jira/browse/TINKERPOP-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15700217#comment-15700217
]
ASF GitHub Bot commented on TINKERPOP-1493:
-------------------------------------------
Github user pauljackson commented on the issue:
https://github.com/apache/tinkerpop/pull/457
It didn’t look intuitively correct, but I didn’t know what was normal.
What’s the easiest way to make this right, right, right? Just start over and
create a new pull request?
Thanks,
-Paul
From: Robert Dale [mailto:notificati...@github.com]
Sent: Sunday, November 27, 2016 8:41 AM
To: apache/tinkerpop
Cc: Paul A. Jackson; Mention
Subject: Re: [apache/tinkerpop] TINKERPOP-1493 Groovy project doesn't build
on Windows (#457)
I didn't consider that your remote branch was behind. Duh. What should have
been done is a forced push git push -f origin tp31 to replace your remote
branch with your local branch. Instead git ended up doing a merge and the
history here looks a little weird because it pulled in all the changes since
your changes. But git does the right thing and it merges cleanly on tp31.
Build passes on Linux. Can't test on windows.
VOTE: +0.5
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on
GitHub<https://github.com/apache/tinkerpop/pull/457#issuecomment-263122753>, or
mute the
thread<https://github.com/notifications/unsubscribe-auth/AAUcSGfiXS20htPRP2UbTre71Si2zbQQks5rCYhqgaJpZM4KVbcO>.
________________________________
> Groovy project doesn't build on Windows
> ---------------------------------------
>
> Key: TINKERPOP-1493
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1493
> Project: TinkerPop
> Issue Type: Bug
> Components: groovy
> Affects Versions: 3.2.2
> Reporter: Paul Jackson
> Assignee: Jason Plurad
> Priority: Minor
>
> Builds on Windows fail for two reasons. First the line to create extTestDir
> is creating a path consisting of two full paths concatenated together. The
> second drive letter is seen as an illegal character:
> {code}private static final File extTestDir = new
> File(System.getProperty("user.dir"),
> TestHelper.makeTestDataDirectory(DependencyGrabberTest.class));{code}
> Second, when it comes time to delete the directory it is locked. This is
> because some instances of JarFile are created on it but not closed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
