[
https://issues.apache.org/jira/browse/TINKERPOP-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15705545#comment-15705545
]
ASF GitHub Bot commented on TINKERPOP-1493:
-------------------------------------------
Github user pluradj commented on the issue:
https://github.com/apache/tinkerpop/pull/457
I reconfirmed with the latest updates and reaffirm my +1 vote from before.
- On Docker, this builds cleanly with `docker/build.sh -t -n -i`
- On Mac, this builds cleanly with `mvn clean install
-DskipIntegrationTests=false`
- On Windows, this builds cleanly with `mvn clean install -DskipTests`
- Following it up with `mvn clean install -DskipIntegrationTests=false`
succeeds all the way until `hadoop-gremlin`
```
[INFO] Apache TinkerPop ................................... SUCCESS [
11.578 s]
[INFO] Apache TinkerPop :: Gremlin Shaded ................. SUCCESS [
3.609 s]
[INFO] Apache TinkerPop :: Gremlin Core ................... SUCCESS [
45.703 s]
[INFO] Apache TinkerPop :: Gremlin Test ................... SUCCESS [
15.797 s]
[INFO] Apache TinkerPop :: Gremlin Groovy ................. SUCCESS [
59.453 s]
[INFO] Apache TinkerPop :: Gremlin Groovy Test ............ SUCCESS [
10.000 s]
[INFO] Apache TinkerPop :: TinkerGraph Gremlin ............ SUCCESS [04:31
min]
[INFO] Apache TinkerPop :: Hadoop Gremlin ................. FAILURE [06:13
min]
```
Although this doesn't completely solve TinkerPop builds on Windows, it
passes a lot more than it used to.
> Groovy project doesn't build on Windows
> ---------------------------------------
>
> Key: TINKERPOP-1493
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1493
> Project: TinkerPop
> Issue Type: Bug
> Components: groovy
> Affects Versions: 3.2.2
> Reporter: Paul Jackson
> Assignee: Jason Plurad
> Priority: Minor
>
> Builds on Windows fail for two reasons. First the line to create extTestDir
> is creating a path consisting of two full paths concatenated together. The
> second drive letter is seen as an illegal character:
> {code}private static final File extTestDir = new
> File(System.getProperty("user.dir"),
> TestHelper.makeTestDataDirectory(DependencyGrabberTest.class));{code}
> Second, when it comes time to delete the directory it is locked. This is
> because some instances of JarFile are created on it but not closed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
