[
https://issues.apache.org/jira/browse/TINKERPOP-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15702606#comment-15702606
]
ASF GitHub Bot commented on TINKERPOP-1443:
-------------------------------------------
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/494
I didn't dig into this too much just yet - I did see this in the travis
logs:
```text
If you want to explicitly ignore this change and provide a justification
for it, add the following JSON snippet to your Revapi configuration under
"revapi.ignore" path:
```
@metlos do you happen to know offhand if this means that if we add a
breaking change of some sort that the `revapi.ignore` will just need to
continue to fill with these exceptions we have to add? Can those be added to an
external file somehow or do they have to be in the pom.xml?
also - what's the reason for `.travis.install-maven.sh`? do we need a
specific version of maven (3.3.9) for this to work?
I generally agree with the listing of initial packages to protect that
@okram provided - i'm not sure if adding those will allow travis to pass, but I
think we'd want to get the build working in full before merging this.
> Use an API checker during build
> -------------------------------
>
> Key: TINKERPOP-1443
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1443
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
> Affects Versions: 3.2.2
> Reporter: Lukas Krejci
>
> Tinkerpop 3.2.2 changed the signature of the method
> {{GraphTraversal.hasLabel}} from {{(String...)}} to {{(String, String...)}}.
> While this is certainly an improvement, it is both source and binary
> incompatible change.
> I.e. even if every usage of {{hasLabel}} had at least one parameter in the
> user code, none of those calls will work until all the user code is
> recompiled using Tinkerpop 3.2.2.
> I don't know the versioning policy of Tinkerpop but changes like the above in
> a micro/patch release are generally unexpected.
> Please consider API checkers like http://revapi.org to warn about such
> incompatible API changes...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
