[
https://issues.apache.org/jira/browse/TINKERPOP-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15705158#comment-15705158
]
ASF GitHub Bot commented on TINKERPOP-1443:
-------------------------------------------
Github user metlos commented on the issue:
https://github.com/apache/tinkerpop/pull/494
@okram the API changes seem to be due to your changes in 05bfb029. You
could try and fill out your first intentional API changes list ;-)
(Most of the below is just git extravaganza - the important bits are points
5, 6 and 7)
1. `git fetch <<NAME_OF_THE_GITHUB_REMOTE_IN_YOUR_CHECKOUT>>`
1. `git checkout -b metlos-api-check-tp32
<<NAME_OF_THE_GITHUB_REMOTE_IN_YOUR_CHECKOUT>>/tp32`
1. `git pull https://github.com/metlos/tinkerpop api-check-tp32`
1. `mvn clean install -DskipTests`
1. copy and paste the JSON snippet output to the build console by revapi
into `gremlin-core/api-changes.json`.
1. Follow the example in that file to ignore the found changes in `3.2.4`
using the JSON snippet from the build.
1. Fill out the justifications for the changes in that snippet (making it a
valid JSON).
1. `git push ssh://[email protected]/metlos/tinkerpop.git
HEAD:api-check-tp32`
1. Watch this PR go green.
> Use an API checker during build
> -------------------------------
>
> Key: TINKERPOP-1443
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1443
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
> Affects Versions: 3.2.2
> Reporter: Lukas Krejci
>
> Tinkerpop 3.2.2 changed the signature of the method
> {{GraphTraversal.hasLabel}} from {{(String...)}} to {{(String, String...)}}.
> While this is certainly an improvement, it is both source and binary
> incompatible change.
> I.e. even if every usage of {{hasLabel}} had at least one parameter in the
> user code, none of those calls will work until all the user code is
> recompiled using Tinkerpop 3.2.2.
> I don't know the versioning policy of Tinkerpop but changes like the above in
> a micro/patch release are generally unexpected.
> Please consider API checkers like http://revapi.org to warn about such
> incompatible API changes...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
