Ok, however I did test on the 3.2.4-SNAPSHOT immediately after Jason's email on the 2/2/2017 and those changes were not there. They are there now but there was a SNAPSHOT release on the 08/02/2017 so things changed. Anyhow that might just be some SNAPSHOT confusion thing.
Next time I'll pull the code and build it manually to make sure. Thanks Pieter On 09/02/2017 22:27, Marko Rodriguez wrote: > Hi, > >> The significant change is >> ffe1b4c Marko A. Rodriguez <okramma...@gmail.com> on 2016/11/15 at 12:44 AM > Ah yea. Thats different from what I thought you had issue with — > has-containers and arrays/collections handling. > >> I don't have a problem with the changes just that is quite a refactor on >> my side as it changes the structure of the HasSteps and its >> HasContainers. I had made some assumptions around how HasSteps and >> HasContainers look when optimizing. > Yea, it “folds left” now so you don’t have to walk over has()-chains. > >> The change is quite old but somehow it was not present in the >> 3.2.4-SNAPSHOT I tested on it when the code freeze announcement was >> made. Not sure what happened there but alas its not giving me enough >> time to get things working again. > I would say don’t wait till releases to test Sqlg. In principle, you should > VOTE on every PR by building and testing the changes against Sqlg. That is > where you can make a huge contribution. > >> So I am not voting negative just requesting a weekend, if possible, to >> get through the refactor. > Again, PR awareness, not release awareness. > > Marko. > > http://markorodriguez.com > > >> Cheers >> Pieter >> >> >> >> >> >> "added TraversalHelper.addHasContainer() on 2016/11/15 >> >> On 09/02/2017 22:11, Stephen Mallette wrote: >>> Unless I'm missing something, HasStep hasn't changed in 4 months and >>> HasContainer hasn't changed in 3 months. The only update that went in after >>> 2/2 that I can think of that would have any bearing for graph providers who >>> tested before/after that date would be the AutoCloseable stuff: >>> >>> https://github.com/apache/tinkerpop/pull/548 >>> >>> Your problems aren't related to that are they? Can you provide some >>> synopsis of where the problems lie? >>> >>> >>> >>> On Thu, Feb 9, 2017 at 2:47 PM, pieter-gmail <pieter.mar...@gmail.com> >>> wrote: >>> >>>> Hi, >>>> >>>> Some issues regarding the release process. >>>> >>>> On the 2/2/2017 the 3.2.4-SNAPSHOT was released. >>>> I then started testing and found almost no issues. >>>> >>>> However yesterday when the VOTE mail came I found many issues on 3.2.4. >>>> To understand the confusion I tested again on 3.2.4-SNAPSHOT and found >>>> the same new issues. >>>> I then checked the 3.2.4-SNAPSHOT timestamp and it changed to 08/02/2017 >>>> >>>> Not sure what happened there as I can not, nor is it worth it, check an >>>> old SNAPSHOT version's binary. >>>> The relevant code changes are quite old (December 2016) but it may have >>>> been done on a separate branch and rebasing may loose the merging >>>> information. Not sure about this though. >>>> >>>> This only leaves the 72 hours to catch up. >>>> >>>> Even though it is a minor release there has been significant changes to >>>> HasStep and HasContainer which breaks the heart (mine at least) of >>>> implementors optimization code. >>>> >>>> Basically to get any value from a vote I for one will need more time. >>>> >>>> So far I have not found any TinkerPop issues but will need at least the >>>> weekend to know better. >>>> >>>> Thanks >>>> Pieter >>>> >>>> On 08/02/2017 16:51, Jason Plurad wrote: >>>>> Hello, >>>>> >>>>> We are happy to announce that TinkerPop 3.2.4 is ready for release. >>>>> >>>>> The release artifacts can be found at this location: >>>>> https://dist.apache.org/repos/dist/dev/tinkerpop/3.2.4/ >>>>> >>>>> The source distribution is provided by: >>>>> apache-tinkerpop-3.2.4-src.zip >>>>> >>>>> Two binary distributions are provided for user convenience: >>>>> apache-tinkerpop-gremlin-console-3.2.4-bin.zip >>>>> apache-tinkerpop-gremlin-server-3.2.4-bin.zip >>>>> >>>>> The GPG key used to sign the release artifacts is available at: >>>>> https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS >>>>> >>>>> The online docs can be found here: >>>>> http://tinkerpop.apache.org/docs/3.2.4/ (user docs) >>>>> http://tinkerpop.apache.org/docs/3.2.4/upgrade/ (upgrade docs) >>>>> http://tinkerpop.apache.org/javadocs/3.2.4/core/ (core javadoc) >>>>> http://tinkerpop.apache.org/javadocs/3.2.4/full/ (full javadoc) >>>>> >>>>> The tag in Apache Git can be found here: >>>>> >>>>> https://git-wip-us.apache.org/repos/asf?p=tinkerpop.git;a= >>>> tag;h=refs/tags/3.2.4 >>>>> The release notes are available here: >>>>> >>>>> https://github.com/apache/tinkerpop/blob/3.2.4/ >>>> CHANGELOG.asciidoc#release-3-2-4 >>>>> The [VOTE] will be open for the next 72 hours --- closing Saturday >>>>> (February 11, 2017) at 10:00 AM EST. >>>>> >>>>> My vote is +1. >>>>> >>>>> Thank you very much, >>>>> Jason Plurad >>>>>
