[
https://issues.apache.org/jira/browse/TINKERPOP-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867799#comment-15867799
]
ASF GitHub Bot commented on TINKERPOP-1443:
-------------------------------------------
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/494
@metlos now that 3.2.4/3.1.6 have been released i thought i'd try to get
the TINKERPOP-1443 branch ready for a final review before merging to master.
i'm not sure if i'm doing something wrong, but i can't seem to get revapi to
fail on build. i thought it would fail immediately when i did a `mvn clean
install -DskipTests` but it seems to build without error. I even added an API
change to a class in one of the packages listed in api-contents.json, but even
then it didn't fail. Am I misinterpreting what I'm seeing somehow or just doing
something wrong?
> Use an API checker during build
> -------------------------------
>
> Key: TINKERPOP-1443
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1443
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
> Affects Versions: 3.2.2
> Reporter: Lukas Krejci
> Assignee: stephen mallette
>
> Tinkerpop 3.2.2 changed the signature of the method
> {{GraphTraversal.hasLabel}} from {{(String...)}} to {{(String, String...)}}.
> While this is certainly an improvement, it is both source and binary
> incompatible change.
> I.e. even if every usage of {{hasLabel}} had at least one parameter in the
> user code, none of those calls will work until all the user code is
> recompiled using Tinkerpop 3.2.2.
> I don't know the versioning policy of Tinkerpop but changes like the above in
> a micro/patch release are generally unexpected.
> Please consider API checkers like http://revapi.org to warn about such
> incompatible API changes...
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
