[
https://issues.apache.org/jira/browse/TINKERPOP-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15801175#comment-15801175
]
ASF GitHub Bot commented on TINKERPOP-1443:
-------------------------------------------
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/494
Thanks @dkuppitz - I wonder if the easiest thing to do right now is to
merge this work into a TinkerPop branch, make some edits so that everything is
working how we want, then re-submit the whole thing as a fresh PR. @metlos do
you see any problems with that approach? was there anything else you wanted to
do to this?
> Use an API checker during build
> -------------------------------
>
> Key: TINKERPOP-1443
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1443
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
> Affects Versions: 3.2.2
> Reporter: Lukas Krejci
>
> Tinkerpop 3.2.2 changed the signature of the method
> {{GraphTraversal.hasLabel}} from {{(String...)}} to {{(String, String...)}}.
> While this is certainly an improvement, it is both source and binary
> incompatible change.
> I.e. even if every usage of {{hasLabel}} had at least one parameter in the
> user code, none of those calls will work until all the user code is
> recompiled using Tinkerpop 3.2.2.
> I don't know the versioning policy of Tinkerpop but changes like the above in
> a micro/patch release are generally unexpected.
> Please consider API checkers like http://revapi.org to warn about such
> incompatible API changes...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
