[
https://issues.apache.org/jira/browse/TINKERPOP-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948990#comment-15948990
]
ASF GitHub Bot commented on TINKERPOP-1438:
-------------------------------------------
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/569
I've finished playing around with my dummy implementation. Just one weird
thing that wasn't easy to see without actually working with the API -
`addTraversalSource()` and `addGraph()` aren't really "adds" - they are "puts"
as calling them more than once will act as a "replace" operation if the key
already exists. I think we want the behavior to generally be a "replace" and
thus "putTraversalSource()" and "putGraph()" seem like better names. I suppose
if an implementation wanted to limit that ability to only "adds" then the
naming with "put" still makes sense as we can see with the use of `Map.put()`
in unmodifiable collections.
I see some other odds/ends that could use a tweak or two, but I'll just
handle those things after merging as I think you have the meat of this PR in
place now once you address those other comments I've made. Please confirm that
you've done a final build with integration tests after all these changes to
make sure it's all solid. At that point, I expect we can get committers to
review/vote.
This has developed into a really nice pull request. Your effort on it is
appreciated.
> Consider GraphManager as an interface
> -------------------------------------
>
> Key: TINKERPOP-1438
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1438
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.2.2
> Reporter: stephen mallette
> Priority: Minor
> Labels: breaking
>
> If {{GraphManager}} were an interface it would make embedding Gremlin Server
> easier as {{Graph}} instances could be more easily supplied by the host
> application. In doing this, It also might be good to force a
> {{TraversalSource}} to be referred to by both the {{Graph}} name and
> {{TraversalSource}} name.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
